Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: print the time the phase took if it was longer than 30s #166827

Merged
merged 1 commit into from
Apr 5, 2022
Merged

stdenv: print the time the phase took if it was longer than 30s #166827

merged 1 commit into from
Apr 5, 2022

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Apr 1, 2022

will be useful for finding why a build runs for a long time on hydra
because of tests or the build etc etc

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 1, 2022
pennae
pennae reviewed Apr 1, 2022
View reviewed changes
pkgs/stdenv/generic/setup.sh Outdated Show resolved Hide resolved
@Mindavi
Copy link
Contributor

Mindavi commented Apr 1, 2022 •
edited

Is it intended that there's newlines?

gettext> configurePhase completed in 1 minutes
gettext> 41 seconds

Seems to work though, so that's already looking good. Implementation seems quite straightforward to me.

@Artturin
stdenv: print the time the phase took if it was longer than 30s
1e2a288 
will be useful for finding why a build runs for a long time on hydra
because of tests or the build etc etc
@Artturin
Copy link
Member Author

Artturin commented Apr 1, 2022

Is it intended that there's newlines?

gettext> configurePhase completed in 1 minutes
gettext> 41 seconds

Seems to work though, so that's already looking good. Implementation seems quite straightforward to me.

fixed

@Artturin Artturin requested a review from pennae April 4, 2022 22:44
pennae
pennae approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@pennae pennae left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. using date +%s opens up possible errors in time reporting if the system clock changes, but that's not something we can easily work around (nor would it matter too much in practice)

@Artturin
Copy link
Member Author

Artturin commented Apr 5, 2022

@ofborg build stdenv.__bootPackages.perl

@Artturin Artturin merged commit e2166cd into NixOS:staging Apr 5, 2022
@Artturin Artturin deleted the addtimeprint branch April 5, 2022 19:13
@Mindavi
Copy link
Contributor

Mindavi commented Apr 5, 2022

Nice! I think this indeed may be useful sometimes, I'm sure a lot of people will find this helpful.

@Artturin Artturin mentioned this pull request May 14, 2022
Closed
9 tasks
@Artturin Artturin mentioned this pull request Jul 3, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennae pennae pennae approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Artturin @Mindavi @pennae