Nologin error #16703
Merged
Nologin error #16703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shadow package's shellPath wasn't detected properly Fixes NixOS#16428
All shell packages must export the shellPath passthru
|
@zimbatm, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @wkennington and @rbvermaa to be potential reviewers |
|
The first commit seems like a no-brainer. The second one I cannot judge (yet). Are you waiting for feedback regarding the 2nd commit? |
|
The second-one exposes the error of the first commit. For legacy reasons we also accept a path as an argument but if it's a package it should expose the shellPath passthru. I wrote all of that code initially so I'm quite confident of what code uses that util. I just like to send PRs just to make sure I didn't miss anything obvious. |
This was referenced Nov 20, 2020
Open
grahamc
added a commit
to grahamc/nixpkgs
that referenced
this pull request
Nov 20, 2020
This fixes a regression reported in NixOS#95778, caused by NixOS#16703.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #16428
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)