Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 1.3.0 -> 1.5.4 #168014

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Conversation

happysalada
Copy link
Contributor

@happysalada happysalada commented Apr 9, 2022

Description of changes

not sure why semver changed so much, it doesn't look like there were a lot of changes
https://github.com/starship/starship/releases

It looks like the build is failing on darwin_x86_64 with a weird error

 = note: Undefined symbols for architecture x86_64:
            "_OBJC_CLASS_$_NSImage", referenced from:
                objc-class-ref in libmac_notification_sys-b1268c23b4664fa0.rlib(notify.o)
            "_LSCopyApplicationURLsForBundleIdentifier", referenced from:
                _setApplication in libmac_notification_sys-b1268c23b4664fa0.rlib(notify.o)
          ld: symbol(s) not found for architecture x86_64
          clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor Author

Alright this is working on linux, so I'm going to merge this, I won't keep linux behind.
upstream has said they would accept a PR to make the notify feature which is problematic optional. Going to do that.

@happysalada happysalada merged commit 24fc487 into NixOS:master Apr 10, 2022
@happysalada happysalada deleted the update_starship branch April 10, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants