Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libwebsockets: 4.3.0 -> 4.3.1 #168304

Merged
merged 1 commit into from
Apr 24, 2022
Merged

libwebsockets: 4.3.0 -> 4.3.1 #168304

merged 1 commit into from
Apr 24, 2022

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented Apr 11, 2022 •
edited
Loading

Description of changes

I think this is the only change?

(Can't find an official changelog)

Changes (no changelog was written AFAICT):

I'm considering dropping all older libwebsockets versions, since they've been unused for a while in nixpkgs now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross-compiled)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • ttyd
7 packages built:
  • ardour
  • collectd
  • domoticz
  • driftnet
  • janus-gateway
  • libwebsockets
  • mosquitto

@Mindavi
Copy link
Contributor Author

Mindavi commented Apr 11, 2022 •
edited
Loading

ttyd is failing to build, investigating...

Probably something in the cmake support files from libwebsockets.

CMake Error at /nix/store/pp182k8lnpr4ab8b8d1r7cwrpnczfl2p-libwebsockets-4.3.1/lib/cmake/libwebsockets/libwebsockets-config.cmake:35 (include):
  include could not find requested file:

    LwsCheckRequirements
Call Stack (most recent call first):
  CMakeLists.txt:54 (find_package)

@fabaff
Copy link
Member

fabaff commented Apr 11, 2022

I'm considering dropping all older libwebsockets versions, since they've been unused for a while in nixpkgs now.

As far as I remember did we keep 3.x for mosquitto but that changed a while back. mosquitto now uses 4.x.

@Mindavi
Copy link
Contributor Author

Mindavi commented Apr 11, 2022 •
edited
Loading

Yeah, I updated mosquitto to use 4.x and it seems to work fine. I haven't done performance testing but it seems to be working fine (see #123917). Also, nobody complained yet which I think also is a good sign.

I'm going to make an issue upstream for ttyd, not sure if they're doing something wrong or if libwebsockets has a bug.

@Mindavi Mindavi mentioned this pull request Apr 11, 2022
Closed
@Mindavi
Copy link
Contributor Author

Mindavi commented Apr 19, 2022 •
edited
Loading

I applied a patch that should fix the issues I saw with ttyd. Now running a nixpkgs-review cycle, but not expecting any remaning (compile) issues.

@Mindavi Mindavi force-pushed the libwebsockets/4.3.1 branch 3 times, most recently from 2472a2b to 7443978 Compare April 19, 2022 17:53
@Mindavi
Copy link
Contributor Author

Mindavi commented Apr 19, 2022

Result of nixpkgs-review pr 168304 run on x86_64-linux 1

8 packages built:
  • ardour
  • collectd
  • domoticz
  • driftnet
  • janus-gateway
  • libwebsockets
  • mosquitto
  • ttyd

@Mindavi
libwebsockets: 4.3.0 -> 4.3.1
da80a59 
Changelog (there's no official one):
- warmcat/libwebsockets@v4.3.0...v4.3.1

Also apply a patch required to make ttyd build again.
This is probably due to a bug in the lws cmake module,
which may only be exercised in this package.
See also tsl0922/ttyd#918.
@Mindavi Mindavi merged commit fccec4a into NixOS:master Apr 24, 2022
@Mindavi Mindavi deleted the libwebsockets/4.3.1 branch April 24, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mindavi @fabaff @SuperSandro2000