android-studio: fixing gui on tiling window managers

[danielbarter]

Description of changes

On tiling window managers like sway, we need to set _JAVA_AWT_WM_NONREPARENTING=1 in the android-studio wrapper for the gui to launch correctly as described here: https://github.com/swaywm/sway/wiki#issues-with-java-applications

Things done

Added an extra argument to the android-studio derivation that lets us set the environment variable in the android-studio wrapper. After change on swaywm

{ pkgs ? import /home/danielbarter/nixpkgs {} }:

with pkgs; mkShell {
  buildInputs =  [
    (android-studio.override { tiling_wm = true;})
  ];
}

provides a working android studio.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[fabianhjr]

LGTM, no test since I don't use sway or other tiling wm.

[danielbarter]

My main concern is if this is the right way to do this. Seems a little messy

[fabianhjr]

I have not done this conditionals but another way would be to add it at the end as an optional.

Examples from nixpkgs:

57-  ''
58:   + (lib.optionalString (lisp-compiler.pname == "ecl") ''
59-     cp src/binary-ecl/maxima.fas* "$out/lib/maxima/${version}/binary-ecl/"
60-   '')

64:  ) ++ lib.optional enableCuda "-DGMX_GPU=CUDA";

39-    "--with-gmp=${lib.getDev gmp}"
40-    "--with-readline=${lib.getDev readline}"
41-  ]
42:  ++ lib.optional stdenv.isDarwin "--host=x86_64-darwin"
43:  ++ lib.optional withThread "--mt=pthread";

Though, not really sure about best practices so can't help much more than pointing some of this examples.

[danielbarter]

ah yeah, that is a little nicer.

[fabianhjr]

LGTM

[fabianhjr]

@ofborg eval

[fabianhjr]

4 packages built:
android-studio androidStudioPackages.beta androidStudioPackages.canary androidStudioPackages.dev

LGTM, evals and builds though ofborg had an issue. Could someone rerun the ofborg eval?

[danielbarter]

When i first opened the PR, github was having some issues i think which is where the borg error came from. Once i rebased, the checks ran normally

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/842