Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana-agent: 0.21.2 -> 0.24.1 #169558

Merged
merged 1 commit into from
Apr 21, 2022
Merged

grafana-agent: 0.21.2 -> 0.24.1 #169558

merged 1 commit into from
Apr 21, 2022

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 21, 2022

We can skip our little patch. The file was removed in
grafana/agent#1362, which includes
grafana/agent#1268.

The condition to exempt network tests was inverted as part of these PRs,
so we now need to set GOFLAGS explicitly to exclude tests that can't run
inside the Nix sandbox.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

We can skip our little patch. The file was removed in
grafana/agent#1362, which includes
grafana/agent#1268.

The condition to exempt network tests was inverted as part of these PRs,
so we now need to set GOFLAGS explicitly to exclude tests that can't run
inside the Nix sandbox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants