mirrors: add downloads.sourceforge.net #16976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downloads.sourceforge.net is the official way to download tarballs from SourceForge. However, it is reported as unreliable due to SF's weird load balancing system. This commit gives the official mirror utmost priority, and will use other configured mirrors (which may be temporary) as a fallback only when the official one can't be reached/download fails/hangs. References: NixOS#16900
|
@phanimahesh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @joachifm and @vcunat to be potential reviewers |
|
before this is merged: Is SF known to support https without issues, and if yes, should we switch to https instead? |
|
The SF mirrors I've tried seem to serve downloads over HTTP. I believe the consensus is that HTTPS for source downloads isn't that important (we rely primarily on checksums for authentication). |
|
Thanks! Makes sense. Checksums are good enough. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloads.sourceforge.net is the official way to download tarballs from
SourceForge. However, it is reported as unreliable due to SF's weird
load balancing system.
This commit gives the official mirror utmost priority, and will use
other configured mirrors (which may be temporary) as a fallback only
when the official one can't be reached/download fails/hangs.
References: #16900