Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.platformdirs: 2.5.1 -> 2.5.2 #169926

Merged
merged 1 commit into from
May 12, 2022
Merged

python3Packages.platformdirs: 2.5.1 -> 2.5.2 #169926

merged 1 commit into from
May 12, 2022

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Apr 23, 2022 •
edited
Loading

Description of changes

Bump platformdirs from 2.5.1 -> 2.5.2 and add necessary dependency hatch-vcs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@cpcloud cpcloud mentioned this pull request Apr 23, 2022
Closed
13 tasks
@jonringer
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot requested a review from fabaff April 23, 2022 20:07
@schlarpc schlarpc mentioned this pull request Apr 25, 2022
Closed
@jyooru
Copy link
Member

jyooru commented May 6, 2022

cc @adisbladis nix-community/poetry2nix#600

@takeda takeda mentioned this pull request May 6, 2022
Closed
@adisbladis adisbladis mentioned this pull request May 7, 2022
Merged
13 tasks
@cpcloud
Copy link
Contributor Author

cpcloud commented May 7, 2022

@FRidh @jonringer @fabaff Is this good to merge?

@SuperSandro2000
Copy link
Member

@ofborg build python3Packages.platformdirs

@cpcloud
Copy link
Contributor Author

cpcloud commented May 12, 2022

@SuperSandro2000 Thoughts? The x86_64-darwin build timed out during building LLVM.

@SuperSandro2000 SuperSandro2000 merged commit 5b1bcc5 into NixOS:staging May 12, 2022
@cpcloud cpcloud deleted the bump-platformdirs branch May 12, 2022 12:40
@cpcloud
Copy link
Contributor Author

cpcloud commented May 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takeda takeda takeda left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpcloud @jonringer @jyooru @SuperSandro2000 @fabaff @takeda