Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assaultcube: 1.2.0.2 -> 1.3.0.2 #169975

Merged
merged 1 commit into from
Apr 26, 2022
Merged

assaultcube: 1.2.0.2 -> 1.3.0.2 #169975

merged 1 commit into from
Apr 26, 2022

Conversation

DarkOnion0
Copy link
Contributor

@DarkOnion0 DarkOnion0 commented Apr 23, 2022 •
edited

Description of changes

Update assaultcube from 1.2.0.2 to 1.3.0.2 (the latest version)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@DarkOnion0 DarkOnion0 force-pushed the aussault-cube branch 2 times, most recently from be0f98a to 8352208 Compare April 23, 2022 20:45
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/832

SuperSandro2000
SuperSandro2000 reviewed Apr 26, 2022
View reviewed changes
pkgs/games/assaultcube/default.nix Outdated Show resolved Hide resolved
pkgs/games/assaultcube/default.nix Outdated Show resolved Hide resolved
pkgs/games/assaultcube/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@DarkOnion0
assaultcube: 1.2.0.2 -> 1.3.0.2
ab968d7 
assaultcube: update meta field

assaultcube: update nix expression

assaultcube: reformat expression

assaultcube: add hooks and update desktop item
@SuperSandro2000
Copy link
Member

@ofborg eval

@gador
Copy link
Contributor

gador commented Apr 26, 2022

Result of nixpkgs-review pr 169975 run on x86_64-linux 1

1 package built:
  • assaultcube

@SuperSandro2000 SuperSandro2000 merged commit a65b7ef into NixOS:master Apr 26, 2022
@DarkOnion0 DarkOnion0 deleted the aussault-cube branch May 12, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@bobby285271 bobby285271 Awaiting requested review from bobby285271

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DarkOnion0 @nixos-discourse @SuperSandro2000 @gador @cole-h