Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.rtl8723ds: init at unstable-2022-10-20 #170421

Merged
merged 1 commit into from Nov 16, 2022
Merged

linuxPackages.rtl8723ds: init at unstable-2022-10-20 #170421

merged 1 commit into from Nov 16, 2022

Conversation

chuangzhu
Copy link
Contributor

@chuangzhu chuangzhu commented Apr 26, 2022 •
edited

Description of changes

Added driver for RTL8723DS. This code is upstreamed from https://github.com/chuangzhu/nixos-sun20iw1p1. Tested on a RISC-V board (LicheeRV Dock).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • riscv64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@chuangzhu chuangzhu changed the base branch from master to staging April 27, 2022 02:41
@chuangzhu
Copy link
Contributor Author

Oh typo

@chuangzhu chuangzhu changed the title linuxPackages.rtl8723bs: init at unstable-2022-04-07 linuxPackages.rtl8723ds: init at unstable-2022-04-07 Oct 15, 2022
@chuangzhu chuangzhu marked this pull request as draft October 15, 2022 10:56
@chuangzhu chuangzhu changed the title linuxPackages.rtl8723ds: init at unstable-2022-04-07 linuxPackages.rtl8723ds: init at unstable-2022-07-27 Oct 18, 2022
@chuangzhu chuangzhu marked this pull request as ready for review October 18, 2022 08:46
@moni-dz
Copy link
Contributor

moni-dz commented Oct 30, 2022

target master instead of staging

@chuangzhu chuangzhu changed the base branch from staging to master October 30, 2022 08:57
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/664

@chuangzhu chuangzhu changed the title linuxPackages.rtl8723ds: init at unstable-2022-07-27 linuxPackages.rtl8723ds: init at unstable-2022-10-20 Nov 3, 2022
@SuperSandro2000 SuperSandro2000 merged commit a0bb254 into NixOS:master Nov 16, 2022
@chuangzhu chuangzhu deleted the rtl8723ds branch November 27, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moni-dz moni-dz moni-dz approved these changes

@xaverdh xaverdh Awaiting requested review from xaverdh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chuangzhu @moni-dz @nixos-discourse @SuperSandro2000