nixos/tailscale: warn if strict reverse path filtering is in use. #170851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danderson
force-pushed
the
danderson/ts-warn-rpf
branch
from
c94a62a
to
c4a660f
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
martinbaillie
approved these changes
May 6, 2022
danderson
force-pushed
the
danderson/ts-warn-rpf
branch
from
c4a660f
to
6b0e2cc
Compare
Tailscale uses policy routing to enable certain traffic to bypass routes that lead into the Tailscale mesh. NixOS's reverse path filtering setup doesn't understand the policy routing at play, and so incorrectly interprets some of this traffic as spoofed. Since this only breaks some features of Tailscale, merely warn users about it, rather than make it a hard error. Updates tailscale/tailscale#4432 Signed-off-by: David Anderson <dave@natulte.net>
danderson
force-pushed
the
danderson/ts-warn-rpf
branch
from
6b0e2cc
to
3fdac0f
Compare
|
Rebased the PR onto master, to make sure the other 2 PRs that got merged didn't produce weird diffs. |
|
I find this warning rather annoying because I don't need the features it's warning about. Should we add a way to silence it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tailscale uses policy routing to enable certain traffic to bypass
routes that lead into the Tailscale mesh. NixOS's reverse path
filtering setup doesn't understand the policy routing at play,
and so incorrectly interprets some of this traffic as spoofed.
Since this only breaks some features of Tailscale, merely warn
users about it, rather than make it a hard error.
Updates tailscale/tailscale#4432
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes