rofi-rbw : init at 0.5.0 #171160
Merged
rofi-rbw : init at 0.5.0 #171160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
gador
suggested changes
May 6, 2022
Comment on lines
9
to
11
| owner = "fdw"; | ||
| repo = "rofi-rbw"; | ||
| rev = "0.5.0"; |
There was a problem hiding this comment.
Suggested change
| owner = "fdw"; | |
| repo = "rofi-rbw"; | |
| rev = "0.5.0"; | |
| owner = "fdw"; | |
| repo = "rofi-rbw"; | |
| rev = version; |
| owner = "fdw"; | ||
| repo = "rofi-rbw"; | ||
| rev = "0.5.0"; | ||
| sha256 = "sha256-EU0rpBEiUB2/jlowq7Dr6r8iY002vWxNGoKlTP+ZyzQ="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-EU0rpBEiUB2/jlowq7Dr6r8iY002vWxNGoKlTP+ZyzQ="; | |
| hash = "sha256-EU0rpBEiUB2/jlowq7Dr6r8iY002vWxNGoKlTP+ZyzQ="; |
| sha256 = "sha256-EU0rpBEiUB2/jlowq7Dr6r8iY002vWxNGoKlTP+ZyzQ="; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ python3Packages.configargparse ]; |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ python3Packages.configargparse ]; | |
| propagatedBuildInputs = [ configargparse ]; |
| @@ -0,0 +1,24 @@ | |||
| { lib, python3Packages, fetchFromGitHub, }: | |||
There was a problem hiding this comment.
Suggested change
| { lib, python3Packages, fetchFromGitHub, }: | |
| { lib, buildPythonPackage, fetchFromGitHub, configargparse}: |
| @@ -0,0 +1,24 @@ | |||
| { lib, python3Packages, fetchFromGitHub, }: | |||
|
|
|||
| python3Packages.buildPythonApplication rec { | |||
There was a problem hiding this comment.
Suggested change
| python3Packages.buildPythonApplication rec { | |
| buildPythonApplication rec { |
gador
reviewed
May 7, 2022
| @@ -0,0 +1,26 @@ | |||
| { lib, buildPythonApplication, fetchFromGitHub, configargparse, pytestCheckHook | |||
There was a problem hiding this comment.
Suggested change
| { lib, buildPythonApplication, fetchFromGitHub, configargparse, pytestCheckHook | |
| { lib, buildPythonApplication, fetchFromGitHub, configargparse |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
gador
approved these changes
May 7, 2022
Co-authored-by: P. <WolfangAukang@users.noreply.github.com>
|
@ofborg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the package rofi-rbw - a bitwarden frontend via rofi and rbw.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesResolves #153841.