python3Packages.preprocess-cancellation: Fetch from PyPi #171190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
| propagatedBuildInputs = [ shapely ]; | ||
|
|
||
| checkInputs = [ pytestCheckHook pytest-cov ]; |
There was a problem hiding this comment.
We want to run tests, not cov, so this is a deterioration.
You are fetching the source tarball, not the wheel. Which is good because that is acceptable while fetching the wheel should be avoided at all time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Package was broken by breaking changes in setuptools 61. Since fixing this requires adding setuptools-specific project discovery configs as well as PEP 621 metadata to
pyproject.tomland upstream uses Poetry, let's just fetch the wheel from PyPi.Unblocks #165896 (comment).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes