Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/restic-rest-server: prometheusNoAuth flag #171238

Closed

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented May 2, 2022

Description of changes

Expose the --prometheus-no-auth flag to the module.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

I think extraFlags is good enough.

@bachp
Copy link
Member

bachp commented Jun 5, 2022

I think extraFlags is good enough.

@dotlambda Is there a recommendation when to expose as a module option vs requiering the use of extraFlags?

@oxzi
Copy link
Member Author

oxzi commented Jun 8, 2022

I think extraFlags is good enough.

Wouldn't this be true for like every flag? Imho, this results in an ugly mixed configuration between "nixified" options and a list of extraFlags. I'd second @bachp's question when which should be used.

@dotlambda
Copy link
Member

The proper solution would be following NixOS/rfcs#42 but that seems a little hard in the case of command line flags.
We could have an option flags that replaces all existing options and translate e.g.

flags = {
  path = "/foo/bar";
  tls = true;
};

to --path "/foo/bar" --tls.

@oxzi oxzi closed this Oct 20, 2022
@oxzi oxzi deleted the restic-rest-server-prometheus-no-auth branch October 20, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants