treewide: chown user:group instead of user.group to fix warnings from coreutils 9.1 #171703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
8.has: documentation
8.has: module (update)
labels
13 tasks
|
The .md/.xml inconsistency at https://github.com/NixOS/nixpkgs/runs/6313067719?check_suite_focus=true#step:4:110 seems to be someone else's fault, unless I'm missing something. |
|
doesn't need to target staging |
|
Reran the manual but still issues, and not seeing them on other PRs. Not sure what's up with that. |
…x warnings from coreutils 9.1 activating the configuration... setting up /etc... chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.messagebus’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ chown: warning: '.' should be ':': ‘root.root’ reloading user units for root...
ivan
requested review from
piegamesde,
adisbladis,
matthewbauer,
FRidh,
jonringer,
a team and
dasJ
as code owners
|
@Mindavi I changed this to target master, does that help? |
ofborg
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
Mindavi
removed request for
a team,
matthewbauer,
FRidh,
jonringer,
piegamesde,
adisbladis and
dasJ
|
Jep, looks good now. |
Mic92
reviewed
May 8, 2022
| mkdir -p /etc/tinc/${network}/invitations | ||
| chown tinc.${network} /etc/tinc/${network}/invitations | ||
| chown tinc:${network} /etc/tinc/${network}/invitations |
There was a problem hiding this comment.
This is not correct. The group is actually called tinc.${network}.
There was a problem hiding this comment.
Sorry about that, I will make a PR
ivan
added a commit
to ivan/nixpkgs
that referenced
this pull request
May 8, 2022
The user is actually tinc.${network}, as Mic92 points out in
NixOS#171703 (comment)
Sorry, I broke this in NixOS#171703 earlier.
coreutils 9.1 chown does not complain in this case with a valid dotted user.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the following warnings when using coreutils 9.1 (#169046) and activating a new NixOS configuration, and also fixes
chown user.groupeverywhere else in the tree.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @Artturin @dasJ @alyssais