Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hatch-vcs: init at 0.2.0 #172205

Closed

Conversation

NorfairKing
Copy link
Contributor

Description of changes

This tries to backport hatch-vcs from here: #171941

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NorfairKing
Copy link
Contributor Author

Looks like this doesn't "just work":

Processing ./hatch_vcs-0.2.0-py2.py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement setuptools-scm>=6.4.0; python_version > "3" (from hatch-vcs) (from versions: none)
ERROR: No matching distribution found for setuptools-scm>=6.4.0; python_version > "3"

@takeda
Copy link
Contributor

takeda commented May 10, 2022

@NorfairKing looks like the version of setuptools_scm probably is older in 21.11.

I think you either will have to update setuptools-scm to version 6.4.0 or higher (I see 21.11 branch uses 6.3.2). This will also affect many packages, but is preferred. The good thing about setuptools-scm is that it should be used only for building so if all packages still build successfully then likely upgrade works.

Alternatively you can see if hatch-vcs can work with older version and patch up the code to remove this requirement.

@NorfairKing
Copy link
Contributor Author

@takeda With nixos-22.05 around the corner, this is probably not worth it for now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants