nixos/hedgedoc: Set StateDirectory to workDir and uploadsPath #172824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to make uploading files possible in the hedgedoc ui.
|
This is wrong. |
13 tasks
yayayayaka
added a commit
to yayayayaka/nixpkgs
that referenced
this pull request
Jun 15, 2022
Commit 8109d8a set the `StateDirectory=` option of the systemd service configuration to the value of `cfg.workDir` which is wrong, according to dasJ [1]. This commit resolves this issue by stripping the `/var/lib/` prefix from `cfg.workDir`. [1] NixOS#172824 (comment)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
Commit 8109d8a set the `StateDirectory=` option of the systemd service configuration to the value of `cfg.workDir` which is wrong, according to dasJ [1]. This commit resolves this issue by stripping the `/var/lib/` prefix from `cfg.workDir`. [1] #172824 (comment) (cherry picked from commit becff58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently, hedgedoc doesn't allow uploading images into documents.
The cause of the failing uploads is, that the "uploadsPath" is not included in the systemd StateDirectories of the service configuration.
Tested on a vanilla NixOS with and without this patch. Without, i cannot upload images, with the patch it works.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes