-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purescript: 0.15.2 -> 0.15.3-3 #174485
purescript: 0.15.2 -> 0.15.3-3 #174485
Conversation
These 0.15.X-N releases are all automated preview releases. See the notes: https://github.com/purescript/purescript/releases/tag/v0.15.3-3, and the announcement on Discourse: https://discourse.purescript.org/t/purescript-continuous-prereleases/3006 These aren't stable releases, and probably shouldn't be added to Nixpkgs (at the very least, they shouldn't become the top-level |
I agree these should not be in nixpkgs (I'm on the PureScript core team). These prereleases are meant for users to be able to check compiler work continuously and are not intended as stable releases. For example, while these prereleases can be downwloaded from NPM using Perhaps this is something that could be changed in https://github.com/ryantm/nixpkgs-update so that prereleases are omitted, at least for this package? |
I imagine that would probably be the best solution, although I'm not familiar with the bot enough to know how easy implementing it would be. At the very least, the bot/package is written in Haskell, so if someone from the PureScript community was interested in fixing this, I imagine they might not have too much trouble. |
Actually, I think the problem is with the update script here in Nixpkgs; this line doesn't take prereleases into account. |
@rhendric That's a good point. That sounds like something I should be able to easily fix then. I'll have to put together a PR for that. |
FYI for when you do that, there's a GitHub endpoint specifically for the latest full release that you might want to use instead of the get-all-releases endpoint. |
Make sure the purescript update script only considers full releases. Before this change, the purescript update script would consider prereleases as valid releases. This caused the r-ryantm bot to create PRs trying to update the purescript derivation in Nixpkgs to prerelease versions. See #174485 (comment) and https://discourse.purescript.org/t/purescript-continuous-prereleases/3006/2?u=cdepillabout for slightly more information.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for purescript is: "A strongly-typed functional programming language that compiles to JavaScript"
meta.homepage for purescript is: "https://www.purescript.org/"
meta.changelog for purescript is: "https://github.com/purescript/purescript/releases/tag/v0.15.3-3"
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 12 packages built:
Maintainer pings
cc @justinwoo @mbbx6spp @cdepillabout for testing.