Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: 0.15.2 -> 0.15.3-3 #174485

Closed
wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for purescript is: "A strongly-typed functional programming language that compiles to JavaScript"

meta.homepage for purescript is: "https://www.purescript.org/"

meta.changelog for purescript is: "https://github.com/purescript/purescript/releases/tag/v0.15.3-3"

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.15.3-3 with grep in /nix/store/c3zcmf2v1hp913dfa6a50pcx3p6znp74-purescript-0.15.3-3
  • found 0.15.3-3 in filename of file in /nix/store/c3zcmf2v1hp913dfa6a50pcx3p6znp74-purescript-0.15.3-3

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
pulp
purescript
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/c3zcmf2v1hp913dfa6a50pcx3p6znp74-purescript-0.15.3-3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A purescript https://github.com/r-ryantm/nixpkgs/archive/78295517f1cd88e39cf2f242514c4486ecf286b6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/c3zcmf2v1hp913dfa6a50pcx3p6znp74-purescript-0.15.3-3
ls -la /nix/store/c3zcmf2v1hp913dfa6a50pcx3p6znp74-purescript-0.15.3-3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • pulp
  • purescript

Maintainer pings

cc @justinwoo @mbbx6spp @cdepillabout for testing.

@cdepillabout cdepillabout marked this pull request as draft May 25, 2022 14:03
@cdepillabout
Copy link
Member

cdepillabout commented May 25, 2022

These 0.15.X-N releases are all automated preview releases. See the notes: https://github.com/purescript/purescript/releases/tag/v0.15.3-3, and the announcement on Discourse: https://discourse.purescript.org/t/purescript-continuous-prereleases/3006

These aren't stable releases, and probably shouldn't be added to Nixpkgs (at the very least, they shouldn't become the top-level purescript derivation). I've changed this PR to a draft so that it doesn't get merged.

@thomashoneyman
Copy link

thomashoneyman commented May 25, 2022

I agree these should not be in nixpkgs (I'm on the PureScript core team). These prereleases are meant for users to be able to check compiler work continuously and are not intended as stable releases. For example, while these prereleases can be downwloaded from NPM using npm i purescript@next, a normal installation npm i purescript will not download a prerelease version.

Perhaps this is something that could be changed in https://github.com/ryantm/nixpkgs-update so that prereleases are omitted, at least for this package?

@cdepillabout
Copy link
Member

Perhaps this is something that could be changed in https://github.com/ryantm/nixpkgs-update so that prereleases are omitted, at least for this package?

I imagine that would probably be the best solution, although I'm not familiar with the bot enough to know how easy implementing it would be. At the very least, the bot/package is written in Haskell, so if someone from the PureScript community was interested in fixing this, I imagine they might not have too much trouble.

@rhendric
Copy link
Member

Actually, I think the problem is with the update script here in Nixpkgs; this line doesn't take prereleases into account.

@cdepillabout
Copy link
Member

@rhendric That's a good point. That sounds like something I should be able to easily fix then. I'll have to put together a PR for that.

@rhendric
Copy link
Member

FYI for when you do that, there's a GitHub endpoint specifically for the latest full release that you might want to use instead of the get-all-releases endpoint.

SuperSandro2000 pushed a commit that referenced this pull request May 27, 2022
Make sure the purescript update script only considers full releases.
Before this change, the purescript update script would consider
prereleases as valid releases.  This caused the r-ryantm bot to
create PRs trying to update the purescript derivation in Nixpkgs
to prerelease versions.

See #174485 (comment)
and
https://discourse.purescript.org/t/purescript-continuous-prereleases/3006/2?u=cdepillabout
for slightly more information.
@r-ryantm r-ryantm deleted the auto-update/purescript branch July 17, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants