Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/vaultwarden: Make example more detailed. #176903

Merged
merged 1 commit into from Jun 14, 2022

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 8, 2022

Description of changes

It took me a while to figure out how to correctly setup vaultwarden on NixOS.

I hope that this more detailed example will help others.

Also addresses #55413 (comment) in more detail, and gives a recommendation on what to use.

Things done

CC past vaulwarden NixOS service contributors: @msteen @WilliButz @ivan @K900 @alarsyo @dywedir

Comment on lines 65 to 67
enable = true;
dbBackend = "sqlite";
config = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an example should only show a possible value for its own option, so here that would be only the attrset inside config = { ... }, without enable, dbBackend etc, which are documented where they're defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed.

It took me a while to figure out how to correctly setup
vaultwarden on NixOS.
I hope that this more detailed example will help others.
@nh2 nh2 force-pushed the vaultwarden-service-better-example branch from a7e547d to 5683c6e Compare June 8, 2022 15:04
@nh2
Copy link
Contributor Author

nh2 commented Jun 14, 2022

Merging since the doc change is rather benign.

@nh2 nh2 merged commit 0652ef9 into NixOS:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants