Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-ng.ocamlPackages_4_05.lablgtk: add -fcommon workaround #178373

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 20, 2022

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

ld: ml_gtktree.o:(.bss+0x0): multiple definition of
  `ml_table_extension_events'; ml_gdkpixbuf.o:(.bss+0x0): first defined here
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: ml_gtktree.o:(.bss+0x0): multiple definition of
      `ml_table_extension_events'; ml_gdkpixbuf.o:(.bss+0x0): first defined here
@veprbl
Copy link
Member

veprbl commented Jun 21, 2022

@GrahamcOfBorg eval

@SuperSandro2000 SuperSandro2000 merged commit abc73a5 into NixOS:master Jun 21, 2022
@trofi trofi deleted the workaround-fno-common-for-ocaml-ng.ocamlPackages_4_05.lablgtk branch June 21, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants