New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libaom: Fix static compilation #179266
Merged
Merged
libaom: Fix static compilation #179266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
added
6.topic: static
6.topic: musl
Running or building packages with musl libc
labels
Jul 2, 2022
dali99
force-pushed
the
libaom_static
branch
2 times, most recently
from
July 8, 2022 20:56
93114f0
to
981ca04
Compare
ofborg
bot
added
10.rebuild-darwin: 2501-5000
and removed
10.rebuild-darwin: 1001-2500
labels
Jul 8, 2022
r-burns
reviewed
Sep 9, 2022
dali99
force-pushed
the
libaom_static
branch
from
September 30, 2022 00:02
5fc1314
to
2baacdd
Compare
dali99
force-pushed
the
libaom_static
branch
from
September 30, 2022 00:15
2baacdd
to
394cc59
Compare
r-burns
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: musl
Running or building packages with musl libc
6.topic: static
10.rebuild-darwin: 501-1000
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
11.by: package-maintainer
12.approvals: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes static compilation for libaom, depends on
#179102#193609 (or we could just merge this one)Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes