Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive.bin.xdvi: pull upstream darwin fix for -fno-common toolchains #179943

Merged
merged 1 commit into from Jul 4, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 2, 2022

Without the change build fails on upstream llvm-11 as:

duplicate symbol '_info' in:
    libxdvi.a(font-open.o)
    libxdvi.a(print-log.o)
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Without the change build fails on upstream llvm-11 as:

    duplicate symbol '_info' in:
        libxdvi.a(font-open.o)
        libxdvi.a(print-log.o)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 2, 2022
@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Jul 2, 2022
@trofi trofi mentioned this pull request Jul 2, 2022
13 tasks
@trofi
Copy link
Contributor Author

trofi commented Jul 4, 2022

@ofborg build texlive.bin.xdvi

@trofi trofi merged commit 3d8f0ff into NixOS:master Jul 4, 2022
@trofi trofi deleted the fix-fno-common-for-texlive.bin.xdvi branch July 4, 2022 23:11
@veprbl
Copy link
Member

veprbl commented Jul 5, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants