Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a52dec: fix build on aarch64-darwin #180194

Merged
merged 1 commit into from Jul 5, 2022
Merged

a52dec: fix build on aarch64-darwin #180194

merged 1 commit into from Jul 5, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Jul 5, 2022

Description of changes

As title.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 5, 2022
@wegank wegank changed the title a52dec: fix build on darwin a52dec: fix build on aarch64-darwin Jul 5, 2022
@wegank wegank requested a review from trofi July 5, 2022 04:39
@wegank
Copy link
Member Author

wegank commented Jul 5, 2022

@ofborg eval

@trofi trofi merged commit a92cae9 into NixOS:staging Jul 5, 2022
@trofi trofi mentioned this pull request Jul 5, 2022
Merged
13 tasks
@wegank wegank deleted the a52dec-darwin branch July 5, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wegank @trofi