Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch update aws packages #180422

Merged
merged 10 commits into from
Aug 28, 2022
Merged

Batch update aws packages #180422

merged 10 commits into from
Aug 28, 2022

Conversation

jiegec
Copy link
Contributor

@jiegec jiegec commented Jul 7, 2022

Description of changes

Closes #184790
Closes #184787

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Closes #180614
Closes #180428

@jiegec
Copy link
Contributor Author

jiegec commented Jul 7, 2022

Oops, it breaks nix, let me look at this.

Update: fixed.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1054

@SuperSandro2000
Copy link
Member

@ofborg build nix

@SuperSandro2000 SuperSandro2000 merged commit a4cd5fd into NixOS:master Aug 28, 2022
@jiegec jiegec deleted the aws branch August 29, 2022 00:14
@vcunat
Copy link
Member

vcunat commented Aug 30, 2022

I believe this PR is what broke build of pkgsi686Linux.aws-sdk-cpp, which blocks i686 ISO and thus also the nixos-unstable channel – i.e. we need to do something about it very soon.

@vcunat
Copy link
Member

vcunat commented Aug 30, 2022

Note that i686-linux had been pinned to an old version of aws-sdk-cpp for a long time.

@vcunat
Copy link
Member

vcunat commented Aug 30, 2022

I forgot to link: https://hydra.nixos.org/build/189042801

@jiegec
Copy link
Contributor Author

jiegec commented Aug 30, 2022

The error message seems the same as aws/aws-sdk-cpp#1940

@jiegec
Copy link
Contributor Author

jiegec commented Aug 30, 2022

We may have to pin aws-crt-cpp to an old version on i686-linux.

@SuperSandro2000
Copy link
Member

With the latest version just a test fails:

aws-sdk-cpp> /build/source/aws-cpp-sdk-core-tests/aws/client/AdaptiveRetryStrategyTest.cpp:190: Failure
aws-sdk-cpp> The difference between step.newTokenBucketRate and retryTokenBucket.T_GetFillRate() is 0.0017265603999998547, which exceeds EPSILON, where
aws-sdk-cpp> step.newTokenBucketRate evaluates to 0.69120000000000004,
aws-sdk-cpp> retryTokenBucket.T_GetFillRate() evaluates to 0.68947343960000018, and
aws-sdk-cpp> EPSILON evaluates to 9.9999999999999995e-07.
aws-sdk-cpp> /build/source/aws-cpp-sdk-core-tests/aws/client/AdaptiveRetryStrategyTest.cpp:190: Failure
aws-sdk-cpp> The difference between step.newTokenBucketRate and retryTokenBucket.T_GetFillRate() is 0.0023503203999999389, which exceeds EPSILON, where
aws-sdk-cpp> step.newTokenBucketRate evaluates to 1.0975999999999999,
aws-sdk-cpp> retryTokenBucket.T_GetFillRate() evaluates to 1.0952496796, and
aws-sdk-cpp> EPSILON evaluates to 9.9999999999999995e-07.
aws-sdk-cpp> /build/source/aws-cpp-sdk-core-tests/aws/client/AdaptiveRetryStrategyTest.cpp:190: Failure
aws-sdk-cpp> The difference between step.newTokenBucketRate and retryTokenBucket.T_GetFillRate() is 0.0014017472944809484, which exceeds EPSILON, where
aws-sdk-cpp> step.newTokenBucketRate evaluates to 3.8218740000000002,
aws-sdk-cpp> retryTokenBucket.T_GetFillRate() evaluates to 3.8204722527055193, and
aws-sdk-cpp> EPSILON evaluates to 9.9999999999999995e-07.
aws-sdk-cpp> /build/source/aws-cpp-sdk-core-tests/aws/client/AdaptiveRetryStrategyTest.cpp:190: Failure
aws-sdk-cpp> The difference between step.newTokenBucketRate and retryTokenBucket.T_GetFillRate() is 0.00055633554627831927, which exceeds EPSILON, where
aws-sdk-cpp> step.newTokenBucketRate evaluates to 4.2003729999999999,
aws-sdk-cpp> retryTokenBucket.T_GetFillRate() evaluates to 4.1998166644537216, and
aws-sdk-cpp> EPSILON evaluates to 9.9999999999999995e-07.
aws-sdk-cpp> /build/source/aws-cpp-sdk-core-tests/aws/client/AdaptiveRetryStrategyTest.cpp:190: Failure
aws-sdk-cpp> The difference between step.newTokenBucketRate and retryTokenBucket.T_GetFillRate() is 0.0019530492986188364, which exceeds EPSILON, where
aws-sdk-cpp> step.newTokenBucketRate evaluates to 3.452226,
aws-sdk-cpp> retryTokenBucket.T_GetFillRate() evaluates to 3.4502729507013812, and
aws-sdk-cpp> EPSILON evaluates to 9.9999999999999995e-07.

@SuperSandro2000
Copy link
Member

That is the same problem that we had in #169909

I don't really want to pin i686 to an older version if we need to start pin other aws libraries to an older version, too.

@SuperSandro2000
Copy link
Member

pkgsi686Linux.nix build on first try, pkgsi686Linux.aws-sdk-cpp is not building and I marked it broken when building with ec2. Not ideal but better than pinning one package right now and more in the future. #188983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants