-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch update aws packages #180422
Batch update aws packages #180422
Conversation
Oops, it breaks nix, let me look at this. Update: fixed. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1054 |
The second patch is included in upstream.
@ofborg build nix |
I believe this PR is what broke build of |
Note that |
I forgot to link: https://hydra.nixos.org/build/189042801 |
The error message seems the same as aws/aws-sdk-cpp#1940 |
We may have to pin aws-crt-cpp to an old version on i686-linux. |
With the latest version just a test fails:
|
That is the same problem that we had in #169909 I don't really want to pin i686 to an older version if we need to start pin other aws libraries to an older version, too. |
|
Description of changes
Closes #184790
Closes #184787
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesCloses #180614
Closes #180428