Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ballerina: init at 2201.1.0 #181319

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Conversation

eigengrau
Copy link
Contributor

@eigengrau eigengrau commented Jul 13, 2022

Description of changes

Ballerina is a programming language specialized for developing network services and data integration.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@eigengrau eigengrau changed the title Add ballerina Ballerina: init add 2201.1.0 Jul 13, 2022
@eigengrau eigengrau changed the title Ballerina: init add 2201.1.0 ballerina: init add 2201.1.0 Jul 13, 2022
pkgs/development/compilers/ballerina/default.nix Outdated Show resolved Hide resolved
@@ -0,0 +1,48 @@
{ ballerina, lib, writeText, runCommand, makeWrapper, fetchzip, stdenv, jdk11 }:
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This let statement can be ommited by just using stdenv.mkDerivation rec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What shall we do about codeName? Since we need a let block for codeName anyway, I figured it would be more convenient for future updates to also put the SHA256 and the version there, seeing that these will all change for the same reason in the future. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe append it to version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won’t help us, since the URL contains both version in isolation and version+codename. Is there anything particularly prohibitive about binding variables? We could hard-code the code-name in the URL, but since this is likely to change in conjunction with the version in the future, it seems preferable to name them explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we resolve this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eigengrau eigengrau requested a review from azahi July 15, 2022 05:14
@SuperSandro2000 SuperSandro2000 changed the title ballerina: init add 2201.1.0 ballerina: init at 2201.1.0 Jul 15, 2022
@@ -0,0 +1,48 @@
{ ballerina, lib, writeText, runCommand, makeWrapper, fetchzip, stdenv, jdk11 }:
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azahi
Copy link
Member

azahi commented Aug 19, 2022

Result of nixpkgs-review pr 181319 run on x86_64-linux 1

1 package built:
  • ballerina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants