-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ballerina: init at 2201.1.0 #181319
ballerina: init at 2201.1.0 #181319
Conversation
@@ -0,0 +1,48 @@ | |||
{ ballerina, lib, writeText, runCommand, makeWrapper, fetchzip, stdenv, jdk11 }: | |||
let |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This let
statement can be ommited by just using stdenv.mkDerivation rec
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What shall we do about codeName
? Since we need a let block for codeName
anyway, I figured it would be more convenient for future updates to also put the SHA256 and the version there, seeing that these will all change for the same reason in the future. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe append it to version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won’t help us, since the URL contains both version in isolation and version+codename. Is there anything particularly prohibitive about binding variables? We could hard-code the code-name in the URL, but since this is likely to change in conjunction with the version in the future, it seems preferable to name them explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we resolve this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1f98a8f
to
cd3591f
Compare
@@ -0,0 +1,48 @@ | |||
{ ballerina, lib, writeText, runCommand, makeWrapper, fetchzip, stdenv, jdk11 }: | |||
let |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of 1 package built:
|
Description of changes
Ballerina is a programming language specialized for developing network services and data integration.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes