xu4: init at 1.3 #181866

mausch · 2022-07-17T16:38:23Z

Description of changes

http://xu4.sourceforge.net/
XU4 is a remake of the computer game Ultima IV.

It requires the original game files, which are not open source and is available from GOG and some other sites. The zip file then needs to be placed in ~/.local/share/xu4.

I'll probably make another PR with a separate unfree package getting that and some graphics upgrade patches so users don't need to set things up manually.

cc @WickedSmoke

Things done

WickedSmoke · 2022-07-17T21:12:16Z

Are you still going to package v1.0 now that 1.1 is available? There are some fixes that users should have.

mausch · 2022-07-17T21:32:42Z

Are you still going to package v1.0 now that 1.1 is available? There are some fixes that users should have.

It'd take me some time to adjust things to the changes in 1.1 and I've been using 1.0 with no issues for some time now...
Eventually we'll upgrade but for now I think it's better than not having the package at all, plus someone else might come along and make the upgrade.

pkgs/games/xu4/default.nix

nixos-discourse · 2023-01-29T17:12:51Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/37

WickedSmoke · 2023-09-02T13:48:42Z

Please note that this package is now three versions behind the latest xu4 1.3 release.

Also, libxml2 is not required if the tlkconv utility is not being built.

mausch · 2023-09-03T09:41:47Z

I just tried updating this.

v1.1+ adds a dependency on https://github.com/WickedSmoke/faun which isn't currently available on nixpkgs so that would have to be packaged first.

v1.2+ seems to get some git submodule during the build. This isn't allowed in Nix as it strictly separates the phase of getting sources from building things. @WickedSmoke can you shed some light into what this gets exactly, why it was necessary, maybe there's some way to work around it? Many thanks.

WickedSmoke · 2023-09-03T16:29:19Z

The GLV submodule is a new backend which is the default on Linux that replaces Allegro. This code is included in the source tarball so I recommend you use that rather than Git. The dist/xu4.spec file for RPM has been updated and may be the best example of how your could package for your distribution.

It's still possible to use Allegro for display & audio, but the official builds use GLV & Faun so that's what I would recommend.

WickedSmoke · 2023-09-03T16:51:49Z

Faun also has an RPM dist/faun.spec file you can study.

Also note that there are five new game & music modules that you could provide as a package (see https://xu4.sourceforge.net/download.php#release).

mausch · 2023-10-01T15:24:57Z

@WickedSmoke I managed to get 1.1 to build with faun but it crashes at startup with:
xu4: error: Unable to obtain OpenGL resource (gui.png)
Apparently related to xu4-engine/u4@df18271 ?

WickedSmoke · 2023-10-01T17:14:49Z

If the gui.png is missing from render.pak then you need to rebuild that file. Perhaps the 1.0 version already exists?

Could you try building the 1.3 version first? I'd like to avoid spending time dealing with outdated ones.

pkgs/games/xu4/default.nix

WickedSmoke · 2023-10-05T01:13:50Z

pkgs/games/xu4/default.nix

+
+  nativeBuildInputs = [ makeWrapper ];
+
+  # there's no `install` target


A make install target does exist. It installs the dist/xu4.desktop item though, which for some reason is ignored and remade below.

Also, why does the binary get copied as $out/share/xu4?

A make install target does exist.

Ah I see it's been added in 1.1 👍 xu4-engine/u4@bb02ea4
However it includes u4upgrade.zip and I haven't been able to find its license so I'm packaging that separately ( #185063 ).

It installs the dist/xu4.desktop item though, which for some reason is ignored and remade below.

Using your desktop file now as of 571e028 👍

Also, why does the binary get copied as $out/share/xu4?

This is so that bin is clean and only contains a single binary (a small wrapper, it's pretty common in Nix) and not the modules and other files.

mausch · 2023-10-14T10:17:46Z

@WickedSmoke Thanks for the reviews! Could you approve the PR to improve the chances of getting merged?

WickedSmoke · 2023-10-14T15:39:16Z

I don't think libXxf86vm is required, so you should try to build without that. Once you've checked that I'll be happy to approve the PR.

mausch · 2023-10-15T10:19:32Z

I don't think libXxf86vm is required, so you should try to build without that.

Done in 2dbdf0b , it works 👍

WickedSmoke

From the game side of things this looks good. Seeing as Mauricio started the packaging process over a year ago I hope the PR is approved soon.

Note that version 1.4 is likely to be released within a month, so you should upgrade ASAP after that. I don't expect any changes for the packaging so a simple version bump should do the trick.

nixos-discourse · 2023-10-29T14:29:09Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1187

SuperSandro2000 · 2023-10-31T20:27:14Z

pkgs/development/libraries/audio/faun/default.nix

+  ];
+
+  configurePhase = ''
+    patchShebangs .


This should be done in postPatch or preConfigure to use the standard configurPhase

Unfortunately the standard configurePhase won't work here because it runs ./configure --prefix=$out which this nonstandard configure doesn't like, it wants ./configure --prefix $out (no equals) 🤷‍♂️
I'll add a comment about this.

Do we just need to to patchShebang the configure script or anything else? It is always nice if we can avoid the . for all files.

SuperSandro2000 · 2023-10-31T20:27:48Z

pkgs/games/xu4/default.nix

+
+  postConfigure = ''
+    # need to report this upstream
+    sed --in-place 's/-Wall/-Wno-error=format-security/g' src/Makefile


Can we disable werror completely?

I don't see Werror set anywhere in the repo 🤷‍♂️

Hmm, that's strange

SuperSandro2000 · 2023-10-31T20:28:07Z

pkgs/games/xu4/default.nix

+  nativeBuildInputs = [ makeWrapper ];
+
+  # The `install` target references some files with unknown license
+  installPhase =


Suggested change

installPhase =

installPhase = ''

Applied in 467e54a

pkgs/games/xu4/default.nix

SuperSandro2000

other than that one comment LGTM

SuperSandro2000 · 2023-12-19T00:28:16Z

pkgs/development/libraries/audio/faun/default.nix

+  ];
+
+  configurePhase = ''
+    patchShebangs .


Do we just need to to patchShebang the configure script or anything else? It is always nice if we can avoid the . for all files.

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 17, 2022

mausch force-pushed the xu4 branch from f72bf4f to 10a46ff Compare July 18, 2022 11:17

mausch force-pushed the xu4 branch from 10a46ff to a56485f Compare August 3, 2022 21:29

mausch mentioned this pull request Aug 3, 2022

ultima-xu4: init at 1.3 #185063

Draft

13 tasks

mausch force-pushed the xu4 branch from a56485f to a684686 Compare December 26, 2022 14:34

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 labels Dec 26, 2022

l0b0 reviewed Jan 9, 2023

View reviewed changes

pkgs/games/xu4/default.nix Outdated Show resolved Hide resolved

mausch force-pushed the xu4 branch from a684686 to 2b01e14 Compare January 10, 2023 19:09

ofborg bot added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jan 10, 2023

mausch force-pushed the xu4 branch from 2b01e14 to 4b20c2b Compare June 15, 2023 21:20

mausch force-pushed the xu4 branch from 4b20c2b to f82943b Compare September 2, 2023 09:39

mausch force-pushed the xu4 branch from f82943b to a0c820f Compare October 1, 2023 18:22

mausch changed the title ~~xu4: init at 1.0~~ xu4: init at 1.1 Oct 1, 2023

mausch force-pushed the xu4 branch 2 times, most recently from 225de84 to b2bdaad Compare October 4, 2023 20:51

mausch changed the title ~~xu4: init at 1.1~~ xu4: init at 1.3 Oct 4, 2023

WickedSmoke reviewed Oct 5, 2023

View reviewed changes

pkgs/games/xu4/default.nix Show resolved Hide resolved

WickedSmoke reviewed Oct 5, 2023

View reviewed changes

mausch force-pushed the xu4 branch 3 times, most recently from a0132b1 to e48fa4e Compare October 8, 2023 16:04

mausch force-pushed the xu4 branch from e48fa4e to 2dbdf0b Compare October 15, 2023 10:16

WickedSmoke approved these changes Oct 15, 2023

View reviewed changes

mausch added the 12.approvals: 1 label Oct 15, 2023

SuperSandro2000 reviewed Oct 31, 2023

View reviewed changes

pkgs/games/xu4/default.nix Outdated Show resolved Hide resolved

mausch force-pushed the xu4 branch 3 times, most recently from 467e54a to 9590333 Compare November 4, 2023 14:47

mausch force-pushed the xu4 branch 2 times, most recently from eb6f8fc to 3512c2e Compare November 25, 2023 11:52

SuperSandro2000 approved these changes Dec 19, 2023

View reviewed changes

mausch added 2 commits January 13, 2024 10:46

faun: init at 0.1.4

b07981d

xu4: init at 1.3

a96885e

mausch force-pushed the xu4 branch from 3512c2e to a96885e Compare January 13, 2024 10:48

mausch mentioned this pull request Jan 13, 2024

Move glv to github? xu4-engine/u4#19

Closed

wegank removed the 12.approvals: 1 label Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xu4: init at 1.3 #181866

xu4: init at 1.3 #181866

mausch commented Jul 17, 2022

WickedSmoke commented Jul 17, 2022

mausch commented Jul 17, 2022

nixos-discourse commented Jan 29, 2023

WickedSmoke commented Sep 2, 2023

mausch commented Sep 3, 2023

WickedSmoke commented Sep 3, 2023

WickedSmoke commented Sep 3, 2023

mausch commented Oct 1, 2023

WickedSmoke commented Oct 1, 2023

WickedSmoke Oct 5, 2023

mausch Oct 7, 2023

mausch commented Oct 14, 2023

WickedSmoke commented Oct 14, 2023

mausch commented Oct 15, 2023

WickedSmoke left a comment

nixos-discourse commented Oct 29, 2023

SuperSandro2000 Oct 31, 2023

mausch Oct 31, 2023 •

edited

SuperSandro2000 Dec 19, 2023

SuperSandro2000 Oct 31, 2023

mausch Oct 31, 2023

SuperSandro2000 Dec 19, 2023

SuperSandro2000 Oct 31, 2023

mausch Oct 31, 2023

SuperSandro2000 left a comment

SuperSandro2000 Dec 19, 2023


		nativeBuildInputs = [ makeWrapper ];

		# there's no `install` target

xu4: init at 1.3 #181866

Are you sure you want to change the base?

xu4: init at 1.3 #181866

Conversation

mausch commented Jul 17, 2022

Description of changes

Things done

WickedSmoke commented Jul 17, 2022

mausch commented Jul 17, 2022

nixos-discourse commented Jan 29, 2023

WickedSmoke commented Sep 2, 2023

mausch commented Sep 3, 2023

WickedSmoke commented Sep 3, 2023

WickedSmoke commented Sep 3, 2023

mausch commented Oct 1, 2023

WickedSmoke commented Oct 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mausch commented Oct 14, 2023

WickedSmoke commented Oct 14, 2023

mausch commented Oct 15, 2023

WickedSmoke left a comment

Choose a reason for hiding this comment

nixos-discourse commented Oct 29, 2023

Choose a reason for hiding this comment

mausch Oct 31, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mausch Oct 31, 2023 •

edited