Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: 0.7.5 -> 1.0.0 #18274

Merged
merged 1 commit into from Sep 3, 2016
Merged

zstd: 0.7.5 -> 1.0.0 #18274

merged 1 commit into from Sep 3, 2016

Conversation

mbbx6spp
Copy link
Contributor

@mbbx6spp mbbx6spp commented Sep 3, 2016

Motivation for this change

Facebook moved made zstd an official facebook organization project and released 1.0.0. Changelog can be found here: facebook/zstd@v0.7.5...v1.0.0

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
$ nix-shell -p nox --run "nox-review wip"
==> We're in a git repo, trying to fetch it
Building in /run/user/1000/nox-review-tybbfig5: zstd
/nix/store/fm40hr2n5sciqvr5bv3lrsgvaymkrzmy-zstd-1.0.0
Result in /run/user/1000/nox-review-tybbfig5
total 0
lrwxrwxrwx 1 spotter users 54 Sep  3 15:31 result -> /nix/store/fm40hr2n5sciqvr5bv3lrsgvaymkrzmy-zstd-1.0.0
  • Tested execution of all binary files (usually in ./result/bin/)
$ nix-shell -p nox --run "nox-review wip"
==> We're in a git repo, trying to fetch it
Building in /run/user/1000/nox-review-tybbfig5: zstd
/nix/store/fm40hr2n5sciqvr5bv3lrsgvaymkrzmy-zstd-1.0.0
Result in /run/user/1000/nox-review-tybbfig5
total 0
lrwxrwxrwx 1 spotter users 54 Sep  3 15:31 result -> /nix/store/fm40hr2n5sciqvr5bv3lrsgvaymkrzmy-zstd-1.0.0

$ cd /run/user/1000/nox-review-tybbfig5/

$ ./result/bin/zstd --version
*** zstd command line interface 64-bits v1.0.0, by Yann Collet ***

$ ./result/bin/zstd --help
*** zstd command line interface 64-bits v1.0.0, by Yann Collet ***
Usage :
      zstd [args] [FILE(s)] [-o file]

FILE    : a filename
          with no FILE, or when FILE is - , read standard input
Arguments :
 -#     : # compression level (1-19, default:3)
 -d     : decompression
 -D file: use `file` as Dictionary
 -o file: result stored into `file` (only if 1 input file)
 -f     : overwrite output without prompting
--rm    : remove source file(s) after successful de/compression
 -k     : preserve source file(s) (default)
 -h/-H  : display help/long help and exit

Advanced arguments :
 -V     : display Version number and exit
 -v     : verbose mode; specify multiple times to increase log level (default:2)
 -q     : suppress warnings; specify twice to suppress errors too
 -c     : force write to standard output, even if it is the console
 -r     : operate recursively on directories
--ultra : enable levels beyond 19, up to 22 (requires more memory)
--no-dictID : don't write dictID into header (dictionary compression)
--[no-]check : integrity check (default:enabled)
--test  : test compressed file integrity
--[no-]sparse : sparse mode (default:enabled on file, disabled on stdout)

Dictionary builder :
--train ## : create a dictionary from a training set of files
 -o file : `file` is dictionary name (default: dictionary)
--maxdict ## : limit dictionary to specified size (default : 112640)
 -s#    : dictionary selectivity level (default: 9)
--dictID ## : force dictionary ID to specified value (default: random)

Benchmark arguments :
 -b#    : benchmark file(s), using # compression level (default : 1)
 -e#    : test all compression levels from -bX to # (default: 1)
 -i#    : minimum evaluation time in seconds (default : 3s)
 -B#    : cut file into independent blocks of size # (default: no block)

$ wc -l ./result/include/zstd.h
587 ./result/include/zstd.h

$ gpg2 --encrypt --recipient       CE87D62D2F7870737B09498EBCC9DA829DB12C14 --armor --output file.asc ./re
sult/include/zstd.h
gpg: EE71B79607FA4306: There is no assurance this key belongs to the named user
sub  rsa2048/EE71B79607FA4306 2014-11-07 keybase.io/mbbx6spp <mbbx6spp@keybase.io>
 Primary key fingerprint: CE87 D62D 2F78 7073 7B09  498E BCC9 DA82 9DB1 2C14
      Subkey fingerprint: A1FC B970 A9A5 BAFD 5B7C  D0EC EE71 B796 07FA 4306

It is NOT certain that the key belongs to the person named
in the user ID.  If you *really* know what you are doing,
you may answer the next question with yes.

Use this key anyway? (y/N) y

$ zstd -9 file.asc -o file.asc.zst
file.asc             : 75.92%   ( 12153 =>   9227 bytes, file.asc.zst)

$ mv file.asc file.asc.orig

$ zstd -d file.asc.zst
file.asc.zst        : 12153 bytes

$ diff file.asc file.asc.orig

Also updated to use the new repository location under facebook organization which is new official home.

Also updated to use the new repository location under facebook organization.
@mention-bot
Copy link

@mbbx6spp, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nckx and @fmu to be potential reviewers

@joachifm
Copy link
Contributor

joachifm commented Sep 3, 2016

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants