haskellPackages.terminfo: not a core pkg if cross compiling #182873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHC's cross build flavours disable the terminfo package, so it will never be included if we are cross-compiling – setting it to null thus breaks all builds depending on the package. To fix this problem, we use the versioned attribute generated by hackage2nix, just like we do for xhtml. Closes NixOS#182785.
cdepillabout
approved these changes
Jul 26, 2022
|
Tried it and my build now works without the pesky |
sternenseemann
added a commit
that referenced
this pull request
Jul 26, 2022
j6carey
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Sep 27, 2023
j6carey
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Nov 10, 2023
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Nov 13, 2023
j6carey
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 7, 2023
j6carey
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 7, 2023
j6carey
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 17, 2023
jsoo1
pushed a commit
to awakesecurity/nixpkgs
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC's cross build flavours disable the terminfo package, so it will
never be included if we are cross-compiling – setting it to null thus
breaks all builds depending on the package.
To fix this problem, we use the versioned attribute generated by
hackage2nix, just like we do for xhtml.
Closes #182785.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes