termscp: 0.8.2 -> 0.9.0

[fgaz]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[viraptor]

Result of nixpkgs-review pr 182947 run on x86_64-darwin 1

1 package failed to build:

• termscp

The following warnings were emitted during compilation:

warning: In file included from objc/notify.m:1:
warning: objc/notify.h:1:9: fatal error: 'Cocoa/Cocoa.h' file not found
warning: #import <Cocoa/Cocoa.h>
warning:         ^~~~~~~~~~~~~~~
warning: 1 error generated.

error: failed to run custom build command for `mac-notification-sys v0.5.0`

[viraptor]

After adding Cocoa to the inputs:

       >   = note: Undefined symbols for architecture x86_64:
       >             "_OBJC_CLASS_$_NSImage", referenced from:
       >                 objc-class-ref in libmac_notification_sys-2ac3330293fe41fe.rlib(notify.o)
       >           ld: symbol(s) not found for architecture x86_64

[viraptor]

Cocoa also needs to be added to all-packages.nix

[viraptor]

Seems to be the same issue as #160876 (comment) but no solution is found there. I'll see if forcing linking AppKit will work.

[viraptor]

These suggestions fix intel darwin compilation for me. I don't have an arm darwin to check, but it may need some other fixups.

[viraptor]

Result of nixpkgs-review pr 182947 run on x86_64-darwin 1

1 package built:

• termscp

works

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/575