-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssm-session-manager-plugin: add "aarch64-linux" support #183260
Conversation
@maxeaubrey Maybe you're the right person to ping? :) |
@WhyNotHugo looks good but I don't have an arm64 nix box to verify. I'm also not sure of the "correctness" of the way the different archs are gated (just visually comparing with other derivations in nixpkgs, not that there's not 50 different approaches 😅) - I'd suggest posting in the "PRs ready for review" thread. |
This one? Done. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1053 |
pkgs/applications/networking/cluster/ssm-session-manager-plugin/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/cluster/ssm-session-manager-plugin/default.nix
Outdated
Show resolved
Hide resolved
23dffa2
to
7b0fc92
Compare
pkgs/applications/networking/cluster/ssm-session-manager-plugin/default.nix
Outdated
Show resolved
Hide resolved
1c7a2dc
to
65b9fbf
Compare
CI seems happy now. I've tested building on aarch64 and amd64. |
@ofborg build ssm-session-manager-plugin |
Can you please fix the commit message to fit the contributing guide? Then ofborg would also be auto triggered. After that we can merge this. |
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#writing-good-commit-messages I don't see any specific convention mentioned. History makes it obvious what I should use, but perhaps an explicit mention in the docs would help? I'm very sure my previous contributions don't fit this very clear convention. |
I think ofborg is happy now. |
Thanks! |
1 similar comment
Thanks!
|
Description of changes
This package has an
if
that covers only linux on amd64 and mac on all platforms. This adds support for linux of arm64.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage I am not using nixOS, so cannot run this../result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesI created a flake that includes this package and it build and worked fine.
CC: @mbaillie