biliass: 1.3.5 -> 1.3.4 #184012
biliass: 1.3.5 -> 1.3.4 #184012
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1050 |
pkgs/top-level/python-packages.nix
Outdated
| protobuf4_21 = callPackage ../development/python-modules/protobuf { | ||
| disabled = isPyPy; | ||
| # If a protobuf upgrade causes many Python packages to fail, please pin it here to the previous version. | ||
| doCheck = !isPy3k; | ||
| protobuf = pkgs.protobuf3_21; | ||
| }; | ||
|
|
There was a problem hiding this comment.
This is not allowed in pythoNPackages. Please do this locally in the package with python package set override.
| @@ -2,20 +2,20 @@ | |||
| , buildPythonPackage | |||
| , fetchPypi | |||
| , pythonOlder | |||
| , protobuf | |||
| , protobuf4_21 | |||
There was a problem hiding this comment.
This is not allowed in pythonPackages because it will cause issues if another protobuf is in the same python env.
There was a problem hiding this comment.
What's the proper fix?
There was a problem hiding this comment.
Move this to an python package override outside of pythonPackages
There was a problem hiding this comment.
Do you mean that I should add it to all-packages.nix or add it as a local override as I do?
There was a problem hiding this comment.
It should be used as a local overwrite in the package that requires it which must be outside of python-modules
There was a problem hiding this comment.
So I should move biliass out of python-modules?
There was a problem hiding this comment.
Ideally if it would be only a CLI which it isn't. Sigh. I am not sure what the best approach is here.
There was a problem hiding this comment.
We cannot handle multiple versions of a package in the same package set. Thus, if you really want it available as an importable library, it simply needs to reuse the protobuf used there. If that's not possible, then we just need to stick with the older version.
There was a problem hiding this comment.
We cannot handle multiple versions of a package in the same package set.
Is this a bug? What's a package set?
Thus, if you really want it available as an importable library, it simply needs to reuse the protobuf used there.
What's an importable library?
If that's not possible, then we just need to stick with the older version.
Do you mean patch the source code to downgrade the lib? By the way, any idea why it suddenly failed to build?
There was a problem hiding this comment.
Is this a bug?
No, a limitation of python.
What's a package set?
eg python39Packages or python310Packages
By the way, any idea why it suddenly failed to build?
It probably failed to build because of an upgrade that happened somewhere.
|
Looks like it's easier to downgrade biliass for now. |
|
@SuperSandro2000 Can this be merged? |
|
Thanks! |
Description of changes
No idea why biliass suddenly stop building due to dep mismatch.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes