plex: remove plexpass #18416
Closed
plex: remove plexpass #18416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemickens, thanks for your PR! By analyzing the annotation information on this pull request, we identified @offlinehacker, @thoughtpolice and @rushmorem to be potential reviewers |
colemickens
force-pushed
the
pr-remove-plexpass
branch
from
cfc7bb7
to
77bff36
Compare
colemickens
force-pushed
the
pr-remove-plexpass
branch
from
77bff36
to
5697295
Compare
|
We probably want an option so people with a plex pass can still use a custom version. |
|
If upstream has asked for the package to be removed, it seems imprudent to delay. |
|
Just a suggestion, not a reason to keep this open as it won't be compatible with the previous option. |
|
Merged as f283e8e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Plex has emailed @thoughtpolice and I asking that links to their Plex Pass downloads be removed.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)NOTE: I'm not running NixOS anywhere so I can't validate this change.