volumeicon: use github as source #184253
Merged
volumeicon: use github as source #184253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1051 |
SuperSandro2000
requested changes
Jul 31, 2022
Currently http://softwarebakery.com/maato is down. The alternative is also based on http, not https. It seems nicer to use github. In order to use GitHub as the source, autogen.sh needs to be executed.
bobvanderlinden
force-pushed
the
pr-volumeicon-github-source
branch
from
d738365
to
6a84883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently the src of volumeicon is down: http://softwarebakery.com/. The website of volumeicon is now http://nullwise.com/volumeicon.html, which also hosts new source. Since the source is not hosted under https I thought I'd use GitHub instead.
In order to use GitHub as the source,
autogen.shneeds to be executed, which introduces a few autoconf build inputs.While I was at it I formatted the derivation a bit.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes