tt-rss: 2021-06-21 -> 2022-08-01

[Smaug123]

Description of changes

Pick up a year's worth of changes from upstream.

I've got an instance of this running, apparently without problems. But there was a database migration of two versions involved, and I didn't have any data to migrate, so I have no idea if this aspect is OK. I also had some trouble cloning the repo until I did nix-prefetch-git at various points - the upstream repository is cgit in a configuration which I think just doesn't serve tarballs? - but eventually nixpkgs-review was happy; and for some reason the feed update daemon didn't start (nor were there any obvious errors) until I rebooted my machine, whereupon it came up happily.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1058

[ajs124]

please make the commit messages follow contributing.md

[Smaug123]

Ah, I was going to squash them down.

[SuperSandro2000]

Suggested change

	- The `tt-rss` service performs two database migrations when you first use its web UI after upgrade; consider backing up its database before starting.
	- The `tt-rss` service will perform database migrations when first visiting the web UI after this upgrade. Consider backing up its database before updating.

[Smaug123]

Sigh, time to polish my bikeshed paintbrush! I can see why you prefer "updating" to "starting" even though "starting" is more accurate (since it won't perform the migrations until you press Go in the UI). But "when first visiting" is strictly less clear than "when you first use" (or "visit"), because 1) the agent of "visiting" is not specified and is weakly implied by the grammar to be "the tt-rss service", which is of course nonsense, and 2) "visiting" is in a continuous tense, whereas the upgrade is performed once when you take a specific action.

[SuperSandro2000]

since it won't perform the migrations until you press Go in the UI

That was not obvious to me from your changelog entry. It sounded more like you must do it before upgrading your system or it is automatically done at startup or immediately when you open the first page in the browser.

[Smaug123]

I believe (though couldn't swear to it) that the UI is essentially blank except for the "upgrade" button, so it renders the system unusable until you press the button.

[Smaug123]

Apologies to anyone I break this way!

[Mic92]

Thanks for your PR. I rebased and updated it here: #198748