Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun: 0.1.5 -> 0.1.6 #184699

Merged
merged 1 commit into from
Aug 2, 2022
Merged

bun: 0.1.5 -> 0.1.6 #184699

merged 1 commit into from
Aug 2, 2022

Conversation

Craftzman7
Copy link
Member

@Craftzman7 Craftzman7 commented Aug 2, 2022

Description of changes

Bump version. I'm also hoping to get this back ported as it introduces new non-breaking functionality.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1061

Copy link
Member

@DAlperin DAlperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as ofborg comes back all good, it LGTM

@winterqt winterqt merged commit 0de1112 into NixOS:master Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Backport failed for release-22.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.05
git worktree add -d .worktree/backport-184699-to-release-22.05 origin/release-22.05
cd .worktree/backport-184699-to-release-22.05
git checkout -b backport-184699-to-release-22.05
ancref=$(git merge-base 3b62a2b3cf46186b677bd4ec94356e758669a2df 84f5edfc93d8404e29f291f93db39c35bce90ef9)
git cherry-pick -x $ancref..84f5edfc93d8404e29f291f93db39c35bce90ef9

@winterqt
Copy link
Member

winterqt commented Aug 2, 2022

If someone makes a PR backporting this, I'll be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants