Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

motrix: init at 1.6.11 #185804

Merged
merged 3 commits into from
Nov 29, 2022
Merged

motrix: init at 1.6.11 #185804

merged 3 commits into from
Nov 29, 2022

Conversation

dit7ya
Copy link
Member

@dit7ya dit7ya commented Aug 9, 2022

Description of changes

Resolves #157984.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/620

SuperSandro2000
SuperSandro2000 reviewed Sep 30, 2022
View reviewed changes
pkgs/tools/networking/motrix/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/motrix/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/motrix/default.nix Outdated Show resolved Hide resolved
@dit7ya @SuperSandro2000
Apply suggestions from code review
0b73dd8 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@ofborg eval

zendo
zendo approved these changes Nov 28, 2022
View reviewed changes
pkgs/tools/networking/motrix/default.nix Show resolved Hide resolved
pkgs/tools/networking/motrix/default.nix Show resolved Hide resolved
pkgs/tools/networking/motrix/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/motrix/default.nix Outdated Show resolved Hide resolved
@dit7ya @zendo
Apply suggestions from code review
7d7bb63 
Co-authored-by: zendo <linzway@qq.com>
@SuperSandro2000 SuperSandro2000 merged commit 8b89e2b into NixOS:master Nov 29, 2022
@zendo zendo mentioned this pull request Nov 29, 2022
Closed
gefla pushed a commit to gefla/nixpkgs that referenced this pull request Nov 30, 2022
@dit7ya
motrix: init at 1.6.11 (NixOS#185804)
0967554 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: zendo <linzway@qq.com>
Resolves NixOS#157984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@zendo zendo zendo approved these changes

@oluceps oluceps oluceps approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request: Motrix
6 participants
@dit7ya @nixos-discourse @SuperSandro2000 @zendo @oluceps @bobby285271