New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scalapack: add darwin support #186209
scalapack: add darwin support #186209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please update this commit message:
maintainers/maintainer-list.nix: add gnd
->maintainers: add gnd
. - Please separate your addition as a maintainer for the package into its own commit, i.e.
scalapack: add gnd as maintainer
orscalapack: add gnd to maintainers
, something like that.
Result of 1 package failed to build:
|
06b18f4
to
9234d52
Compare
Build completely, but couldn't finish the tests on intel darwin. They ended up hanging for over 20min on the test 69 (can't get the test name once it's finished). |
9234d52
to
de1425a
Compare
Latest push skips tests on x86 darwin. The tests that seem to be hanging are xslu and xsllt (out of 70 tests total). Both tests have several dozen successful runs; xsllt seems to just time out, whereas xslu gives this output (there are several dozen PASSED lines preceding this, omitted for brevity):
I've contacted some people about this to see if it's a known issue or not. Not familiar enough with nixpkgs norms to say whether this is sufficient to warrant the package being marked as broken on x86_64-darwin or not, since it does appear to build fine if the tests are skipped. |
Result of 1 package built:
|
From my experience, it is not a good idea to skip broken tests in |
Result of 1 package failed to build:
|
de1425a
to
2464f69
Compare
Marked as broken on x86_64-darwin (brave souls who are ok with unpredictable behavior can still successfully build without tests using NIXPKGS_ALLOW_BROKEN=1). |
It seems that on |
That's very strange... I'm not seeing the issue on my laptop (M1 pro, 8-core). Wondering if this is a hardware-dependent thing (e.g. chip-dependent memory bug, or some strange corner case that sometimes but doesn't always happen - iirc the previous commit, which was identical for aarch64-darwin built properly in OfBorg). Given that the OfBorg eval failed with a SIGTRAP I'm wondering if this might be an upstream bug. From my machine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's give it a try and see if Hydra can build it on aarch64-darwin.
Description of changes
Add darwin support to scalapack.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes