Fix mk flutter app #186839
Closed
Fix mk flutter app #186839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also fix #163515 |
|
the vendorHash in the fluffychat patch isn’t reproducible, i got |
Hmm that's weird, ofborg seems to successfully build |
|
Maybe it's because of a new version of flutter being merged? |
|
No you are right seems to be unreproducible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After upgrading flutter to version 3 in #173200 I found a bug in the mkFlutterApp
which only successfully build the app if it used flutter plugins. I removed that necessity and cleaned up the code a bit.
Alongside these changes I had to recalculate the vendorHash of the packages: fluffychat and firmware-updater while also simultaneously upgrading fluffychat to the newest version and fix the build issues.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes