Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localstack: init at 1.0.4 #188118

Merged
merged 4 commits into from
Sep 13, 2022
Merged

localstack: init at 1.0.4 #188118

merged 4 commits into from
Sep 13, 2022

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 24, 2022

Description of changes

Add the mock aws service to nixpkgs

closes: #50445

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

Also builds on x86_64-linux

https://github.com/NixOS/nixpkgs/pull/188118

8 packages built:
localstack python310Packages.localstack-client python310Packages.localstack-ext python310Packages.plux python39Packages.localstack python39Packages.localstack-client python39Packages.localstack-ext python39Packages.plux

@b12f
Copy link
Contributor

b12f commented Aug 24, 2022

Result of nixpkgs-review pr 188118 run on x86_64-linux 1

8 packages built:
  • localstack (python310Packages.localstack)
  • python310Packages.localstack-client
  • python310Packages.localstack-ext
  • python310Packages.plux
  • python39Packages.localstack
  • python39Packages.localstack-client
  • python39Packages.localstack-ext
  • python39Packages.plux

@jonringer
Copy link
Contributor Author

Going to merge for now, I think having the client available is still valuable, even if we don't have the ability to run it outside of docker right now.

@jonringer jonringer merged commit 0dde2e2 into NixOS:master Sep 13, 2022
@jonringer jonringer deleted the add-localstack branch September 13, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to package localstack
2 participants