Intellij Idea: depend on system Go debugger delve #188488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the size of the overall Intellij Idea build and after discussion with @Mic92 we thought it was reasonable to make idea depend on the NixOS-packaged version of the Go debugger delve, even though it is only needed when using the Go plugin. This is accomplished by setting `dlv.path` (see this comment on the Jetbrains issue tracker for reference: https://youtrack.jetbrains.com/issue/GO-11782/Run-Targets-Debugging-in-a-remote-Docker-container-on-Apple-Silicon-fails#focus=Comments-27-5280341.0-0) which instructs intellij to use a custom `dlv` binary (i.e. not the one which is bundled with Goland or downloaded by the Plugin which requires various linking fixes. Note: this patch leaves the existing the postFixup block from the Goland build which patches the bundled `dlv`. For Goland the patching approach has the modest benefits of: 1. Not showing a popup balloon popup when debugging saying 'using custom dlv...` 2. Guaranteeing Goland is given access to the exact version of delve with which it is bundled. 1 is a fairly minor inconvenience, and in the case of 2 I think delve is reasonably stable at this point so is unlikely to cause a problem. It would be possible to use the system `dlv` for Goland and the Go plugin if consistency is preferred. Signed-off-by: Silas Davis <silas.davis@monax.io>
silasdavis
force-pushed
the
intellij-ultimate-dlv
branch
from
8bcdfd1
to
b7399cd
Compare
silasdavis
changed the title
silasdavis
commented
Aug 27, 2022
| @@ -12032,6 +12032,16 @@ | |||
| fingerprint = "ADF4 C13D 0E36 1240 BD01 9B51 D1DE 6D7F 6936 63A5"; | |||
| }]; | |||
| }; | |||
| silasdavis = { | |||
There was a problem hiding this comment.
I had this lying around and thought I'd add my contact details, not sure if I should be a maintainer for any jetbrains stuff just because of this one change, but I expect to add some other packages so I thought I'd commit this now. Obviously I can pull it out if that is cleaner.
|
@silasdavis are you still interested in getting this merged? |
|
Merge conflict, please rebase and create a new one for more attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the size of the overall Intellij Idea build and after discussion
with @Mic92 we thought it was reasonable to make idea depend on the
NixOS-packaged version of the Go debugger delve, even though it is only
needed when using the Go plugin.
This is accomplished by setting
dlv.path(see this comment on theJetbrains issue tracker for reference:
https://youtrack.jetbrains.com/issue/GO-11782/Run-Targets-Debugging-in-a-remote-Docker-container-on-Apple-Silicon-fails#focus=Comments-27-5280341.0-0) which instructs intellij to use a custom
dlvbinary (i.e. not the one which is bundled with Goland or downloaded by the Plugin which requires various linking fixes.Note: this patch leaves the existing the postFixup block from the Goland
build which patches the bundled
dlv. For Goland the patching approachhas the modest benefits of:
Not showing a popup balloon popup when debugging saying 'using custom dlv...`
Guaranteeing Goland is given access to the exact version of delve with which
it is bundled.
1 is a fairly minor inconvenience, and in the case of 2 I think delve is reasonably
stable at this point so is unlikely to cause a problem.
It would be possible to use the system
dlvfor Goland and the Goplugin if consistency is preferred.
Signed-off-by: Silas Davis silas.davis@monax.io
Description of changes
See above
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes