Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcgi: Patch to protect against stack smashing #18919

Merged
merged 1 commit into from
Sep 25, 2016
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 24, 2016

Motivation for this change

https://lwn.net/Vulnerabilities/642646/
#18856

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @urkud, @edolstra and @MarcWeber to be potential reviewers

@grahamc grahamc added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 24, 2016
@grahamc grahamc merged commit fe27ae5 into NixOS:master Sep 25, 2016
@grahamc grahamc removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 25, 2016
@grahamc grahamc deleted the fcgi branch September 25, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants