google-chrome: place commandLineArgs after wayland args #189199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow I was just wondering why the flag |
|
Actually, since this is needed here, it's also needed on chromium and the other chromium-based browsers, right? @stefanradziuk would you mind updating those as well? |
13 tasks
|
Created #189371. I think it's only chromium that needs an update. Brave already has flags in the correct order. Let me know if I missed anything. |
13 tasks
primeos
pushed a commit
to primeos/nixpkgs
that referenced
this pull request
Sep 2, 2022
(cherry picked from commit 1be806f)
primeos
pushed a commit
to primeos/nixpkgs
that referenced
this pull request
Sep 2, 2022
(cherry picked from commit 1be806f)
RaitoBezarius
pushed a commit
to RaitoBezarius/nixpkgs
that referenced
this pull request
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working around what seems to be a bug in Chrome. I noticed Chrome would only observe
--enable-features=WebUIDarkModeif it was placed after--enable-features=UseOzonePlatform --ozone-platform=wayland.I haven't been able to find a relevant upstream issue yet so can't fully confirm the consequences of this bug. It might be possible that users will need to pass some flags before and some flags after the wayland flags to work around some issues. A temporary workaround could be to have users unset
NIXOS_OZONE_WLand instead put all the args incommandLineArgsin the necessary order.ungoogled-software/ungoogled-chromium#1778 (comment) seems to describe the same issue, so chances are this also affects other chrom* packages, but I haven't had a chance to test that.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @wmertens