Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lua plugins #190067

Merged
merged 2 commits into from
Sep 11, 2022
Merged

add lua plugins #190067

merged 2 commits into from
Sep 11, 2022

Conversation

teto
Copy link
Member

@teto teto commented Sep 6, 2022

Goal is to address #183304 and pave the way for #185397
I noticed that instead of running luarocks-nix with the correct interpreter, we could instead pass the --lua-version flag which can eliminate 2/3 builds.

I've added a few packages and was a bit too lazy to write a proper history.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member Author

teto commented Sep 7, 2022

seems like I need to fix rest.nvim's rockspec :'(

luarocks install rest.nvim --tree /tmp
Warning: Lua 5.1 interpreter not found at lua

Modules may not install with the correct configurations. You may want to configure the path prefix to your build of Lua 5.1 using

   luarocks config --local lua_dir <your-lua-prefix>

sh: line 1: lua/lua: No such file or directory
Installing https://luarocks.org/rest.nvim-0.1-1.rockspec

Error: Error fetching file: Failed downloading http://github.com/rest-nvim/rest.nvim/archive/v0.1.zip - failed downloading http://github.com/rest-nvim/rest.nvim/archive/v0.1.zip

@teto
Copy link
Member Author

teto commented Sep 11, 2022

this passes nixpkgs-review well.

@teto teto merged commit 5e29057 into NixOS:master Sep 11, 2022
@teto teto deleted the add-lua-plugins branch September 11, 2022 18:20
instead of running luarocks with the requested interpreter, we can ask any interpreter to search for a specific version via --lua-version. It avoids building/running different luarocks-nix just for that.

use tagged release of nvim-cmp
- had to disable the failing lush-nvim tests (it can't find
  vim.api.nvim_command for a myssterious reason).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant