Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spire: 1.4.0 -> 1.4.1 #190179

Merged
merged 1 commit into from
Sep 7, 2022
Merged

spire: 1.4.0 -> 1.4.1 #190179

merged 1 commit into from
Sep 7, 2022

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Sep 7, 2022

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/spiffe/spire/releases.

meta.description for spire is: "The SPIFFE Runtime Environment"

meta.homepage for spire is: "https://github.com/spiffe/spire"

meta.changelog for spire is: "https://github.com/spiffe/spire/releases/tag/v1.4.1"

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.4.1 in filename of file in /nix/store/4nin6mhh2j3hdm4ba4b6lp54jp5w1jij-spire-1.4.1

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
spire
spire-agent
spire-server
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4nin6mhh2j3hdm4ba4b6lp54jp5w1jij-spire-1.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A spire https://github.com/r-ryantm/nixpkgs/archive/3399cf9bc0fc74799a0149b61f172b1de7f9f332.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4nin6mhh2j3hdm4ba4b6lp54jp5w1jij-spire-1.4.1
ls -la /nix/store/4nin6mhh2j3hdm4ba4b6lp54jp5w1jij-spire-1.4.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • spire
  • spire-agent
  • spire-server

Maintainer pings

cc @jonringer @fkautz for testing.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 190179 run on x86_64-linux 1

3 packages built:
  • spire
  • spire-agent
  • spire-server

@jonringer jonringer merged commit 4ffd6bd into NixOS:master Sep 7, 2022
jonringer added a commit to jonringer/nixpkgs-update that referenced this pull request Sep 7, 2022
I split spire into 3 different outputs https://github.com/NixOS/nixpkgs/blob/4ffd6bd6f6b6bfdf2c7810bbad09ac46582613b3/pkgs/tools/security/spire/default.nix#L7, one agent, one server, and the default contains both.

The reasoning was that most scenarios need to use one or the other but not both, so it didn't make sense to always have both in every scenario. This is great for smaller runtime closures, but a bit odd for nixpkgs-update as there's three attrs which point to the same package.

Example updates:
- NixOS/nixpkgs#190177
- NixOS/nixpkgs#190178
- NixOS/nixpkgs#190179
@r-ryantm r-ryantm deleted the auto-update/spire branch September 7, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants