lib.types: Add parentheses where description is ambiguous #191353
Merged
+122
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
piegamesde
reviewed
Sep 15, 2022
roberth
force-pushed
the
types-parentheses
branch
from
e4b256a
to
7c106f0
Compare
Profpatsch
reviewed
Sep 16, 2022
ilkecan
reviewed
Sep 17, 2022
roberth
force-pushed
the
types-parentheses
branch
from
7c106f0
to
1cbe950
Compare
infinisil
reviewed
Sep 23, 2022
Comment on lines
+253
to
+254
| name = "unspecified value"; | ||
| descriptionClass = "noun"; |
There was a problem hiding this comment.
This isn't right, the name shouldn't be changed, but instead a description should be added
There was a problem hiding this comment.
Doesn't seem to lead to a problem, but here's the cleanup #192755
roberth
added a commit
to hercules-ci/nixpkgs
that referenced
this pull request
Sep 24, 2022
@infinisil: This isn't right, the name shouldn't be changed, but instead a description should be added NixOS#191353 (comment)
13 tasks
github-actions bot
pushed a commit
to arcnmx/nixpkgs-lib
that referenced
this pull request
Oct 14, 2022
@infinisil: This isn't right, the name shouldn't be changed, but instead a description should be added NixOS/nixpkgs#191353 (comment)
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Oct 16, 2022
@infinisil: This isn't right, the name shouldn't be changed, but instead a description should be added NixOS/nixpkgs#191353 (comment)
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Dec 4, 2022
@infinisil: This isn't right, the name shouldn't be changed, but instead a description should be added NixOS/nixpkgs#191353 (comment)
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
May 31, 2023
@infinisil: This isn't right, the name shouldn't be changed, but instead a description should be added NixOS/nixpkgs#191353 (comment)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Alternative to #180007
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes