Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init phetch #191715

Merged
merged 2 commits into from Apr 11, 2023
Merged

Init phetch #191715

merged 2 commits into from Apr 11, 2023

Conversation

felixalbrigtsen
Copy link
Member

@felixalbrigtsen felixalbrigtsen commented Sep 17, 2022 •
edited

Description of changes

Added package phetch(https://github.com/xvxx/phetch), a gopher client written in rust.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@felixalbrigtsen felixalbrigtsen marked this pull request as ready for review September 17, 2022 22:52
dali99
dali99 suggested changes Sep 18, 2022
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
dali99
dali99 suggested changes Sep 18, 2022
View reviewed changes
Copy link
Member

@dali99 dali99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to squash your commits together so that there are only two, one for adding the maintainer, and one for adding the package.

you can use interactive rebase and fixups to accomplish this

pkgs/applications/networking/gopher/phetch/default.nix Outdated Show resolved Hide resolved
@felixalbrigtsen felixalbrigtsen force-pushed the init-phetch branch 2 times, most recently from 67c9dbf to 9885837 Compare January 19, 2023 21:10
pbsds
pbsds approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixalbrigtsen felixalbrigtsen force-pushed the init-phetch branch 2 times, most recently from 740e63b to 64b95a3 Compare January 19, 2023 22:19
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/36

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1757

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 175667e into NixOS:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds approved these changes

@dali99 dali99 dali99 approved these changes

@h7x4 h7x4 h7x4 approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 3+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@felixalbrigtsen @nixos-discourse @SuperSandro2000 @pbsds @dali99 @h7x4 @Janik-Haag