zsh-syntax-highlighting: init at 0.4.1

[loskutov]

Motivation for this change

zsh-syntax-highlighting is a popular package (available in Ubuntu, homebrew, etc.), lacking in nixpkgs.

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[loskutov]

It also requires something like source /run/current-system/sw/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh in programs.zsh.interactiveShellInit to work. Is it a good idea to leave a comment about it, or add an entry to config.programs.zsh, or do something else?

[langston-barrett]

@loskutov You could add a new configuration option to nixpkgs/nixos/modules/programs/zsh/zsh.nix that would automatically add that line at the end of the interactiveShellInit.

somewhere in here you could add something like

${optionalString (cfg.syntaxHighlighting) "source /run/current-system/sw/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh"}

and add the appropriate mkOption.

[Mic92]

I would also leave a comment in the package itself.

[Mic92]

I had to adapt the source line a little (9f34b55#diff-0740f57e63af61694d14796286cb9204R132), but then it worked. Thanks!

[langston-barrett]

Working perfectly. Thanks @Mic92, @loskutov!