Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.pnpm: 7.12.0 -> 7.12.2 #191996

Merged
merged 1 commit into from
Sep 26, 2022
Merged

nodePackages.pnpm: 7.12.0 -> 7.12.2 #191996

merged 1 commit into from
Sep 26, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Sep 20, 2022

Description of changes

Picks up bugfixes to 7.12.0:

https://github.com/pnpm/pnpm/releases/tag/v7.12.1
https://github.com/pnpm/pnpm/releases/tag/v7.12.2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni changed the title nodePackages.pnpm: 7.12.0 -> 7.12.1 nodePackages.pnpm: 7.12.0 -> 7.12.2 Sep 23, 2022
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on x86_64 NixOS master by making sure this updated nixpkgs pnpm could build pnpm from the pnpm repo. I did not see any issues.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/614

@winterqt
Copy link
Member

@ofborg build nodePackages.pnpm

@winterqt
Copy link
Member

That was fast!

@winterqt winterqt merged commit 28845fc into NixOS:master Sep 26, 2022
@tjni tjni deleted the pnpm-update branch September 26, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants