crosvm: 104.0 -> 107.1 #193746
Merged
crosvm: 104.0 -> 107.1 #193746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astro
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Works but only if I keep passing --seccomp-log-failures. Without it fails on x86_64:
[2022-10-03T18:36:28.237798106+02:00 INFO devices::acpi] Listening on acpi_mc_group of acpi_event family
[2022-10-03T18:36:28.380173248+02:00 ERROR crosvm::crosvm::sys::unix] child xhci controller (pid 1889588) died: signo 17, status 31, code 3
[2022-10-03T18:36:28.380920135+02:00 ERROR devices::proxy] failed write to child device process xhci controller: failed to send packet: Broken pipe (os error 32)
[2022-10-03T18:36:28.381030180+02:00 ERROR devices::proxy] failed to read result of Shutdown from child device process xhci controller: tube was disconnected
[2022-10-03T18:36:28.446001964+02:00 INFO crosvm] crosvm has exited normally
[2022-10-03T18:36:28.446516208+02:00 INFO crosvm] exiting with success
nesteroff
pushed a commit
to nesteroff/nixpkgs-spectrum
that referenced
this pull request
Oct 11, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS/nixpkgs#193746 Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com>
vilvo
pushed a commit
to tiiuae/nixpkgs-spectrum
that referenced
this pull request
Oct 13, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS/nixpkgs#193746 Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com>
unbel13ver
pushed a commit
to tiiuae/nixpkgs-spectrum
that referenced
this pull request
Oct 14, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS/nixpkgs#193746 Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com>
vilvo
pushed a commit
to tiiuae/nixpkgs-spectrum
that referenced
this pull request
Oct 26, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS/nixpkgs#193746 Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com> Message-Id: <20220930210906.1696349-2-alyssa.ross@unikie.com>
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
Nov 15, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS#193746 Signed-off-by: Alyssa Ross <alyssa.ross@unikie.com> Message-Id: <20220930210906.1696349-2-alyssa.ross@unikie.com>
|
I've updated this to the latest crosvm, and backported a patch that fixes the sandboxing issue, but there's a new problem, which is that it doesn't build for aarch64. |
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: NixOS#193746
For R106 and onwards, upstream has gone back to not having a separation between chromeos and not.
crosvm now includes a Cargo.lock again, so we don't need to vendor it into Nixpkgs. Its build system now compiles the seccomp policies into the binary, so we don't need to build and install those ourselves any more.
This is no longer required as crosvm now includes a Cargo.lock in-tree again.
|
aarch64 build is fixed, both cross and native. @astro can you check everything looks okay for you? |
|
Nice! Works for me on x86_64. |
astro
approved these changes
Nov 18, 2022
alyssais
added a commit
that referenced
this pull request
Nov 18, 2022
Despite having moved the main repo to crosvm/crosvm, release branches are still only being created on chromiumos/platform/crosvm. So we should have crosvm/crosvm as the homepage, but fetch from chromiumos/platform/crosvm. Link: #193746
astro
added a commit
to astro/microvm.nix
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes