Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libajantv2: init at 16.2-bugfix5 #194572

Merged
merged 1 commit into from
Oct 8, 2022
Merged

libajantv2: init at 16.2-bugfix5 #194572

merged 1 commit into from
Oct 8, 2022

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Oct 5, 2022 •
edited

Description of changes

Init libajantv2 as preparation for obs-studio update (new dependency)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SebTM SebTM mentioned this pull request Oct 5, 2022
Merged
13 tasks
azahi
azahi requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@azahi azahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the commit message and the name of the PR to: libajantv2: init at 16.2-bugfix5

pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
azahi
azahi requested changes Oct 5, 2022
View reviewed changes
pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libajantv2/default.nix Outdated Show resolved Hide resolved
@SebTM SebTM changed the title libajantv2: init at 16.2-5 libajantv2: init at 16.2-bugfix5 Oct 5, 2022
@SebTM
Copy link
Contributor Author

SebTM commented Oct 5, 2022

@azahl Thanks for your feedback, I appreciate it - fixed everything you mentioned :)

@azahi
Copy link
Member

azahi commented Oct 5, 2022

Result of nixpkgs-review pr 194572 run on x86_64-linux 1

1 package built:
  • libajantv2

@SuperSandro2000 SuperSandro2000 merged commit 81885ee into NixOS:master Oct 8, 2022
@SebTM SebTM deleted the add/libajantv2_1625 branch October 9, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azahi azahi azahi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SebTM @azahi @SuperSandro2000